Include the line number when using HTML output format#683
Conversation
ghost
requested review from
ericwb,
ghugo,
lukehinds and
sigmavirus24
as code owners
ericwb
changed the title
ericwb
requested changes
Dec 27, 2020
Member
ericwb
left a comment
ericwb
left a comment
There was a problem hiding this comment.
Looks mostly ready. Ideally you could include the column number too, but could be in a separate PR. Thanks for the PR!
| <b>Confidence: </b>{confidence}<br> | ||
| <b>File: </b><a href="{path}" target="_blank">{path}</a> <br> | ||
| <b>Line number: </b>{line_number}</a> <br> | ||
| <b>More info: </b><a href="{url}" target="_blank">{url}</a><br> |
Member
There was a problem hiding this comment.
How about also adding the column number? Thanks
Author
There was a problem hiding this comment.
No problem! I'll attempt that change in another PR. Thanks for taking a look!
ericwb
requested changes
Dec 27, 2020
Member
ericwb
left a comment
ericwb
left a comment
There was a problem hiding this comment.
Oops, just noticed a stray in your HTML
…using HTML output format. Resolves: #672
ericwb
approved these changes
Dec 27, 2020
This was referenced Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is to include the line number of a given occurrence when using HTML output format.
Resolves: #672