#694 Bandit fails when using importlib with named arguments#701
Merged
Conversation
Member
|
I think we run tests against the |
Contributor
Author
|
@sigmavirus24 ah, that makes sense now. I've added two new examples to the import-with-imposelib.py. Thanks for pointing that out |
sigmavirus24
approved these changes
Mar 31, 2021
Contributor
Author
|
@sigmavirus24 I've found one more interesting case. When these new tests are executed against master they are not failing the build because bandit throws an exception and continues with execution so I've updated the results to follow incremented values and changed the modules in the tests to trigger additional issues. Also I've updated tests to include just |
mikespallino
pushed a commit
to mikespallino/bandit
that referenced
this pull request
Jan 7, 2022
This was referenced Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when importlib is being used with named arguments outlined in the #694.
Following cases are found:
importlib.import_module("foo", "bar.baz")results incall_args = ["foo", "bar.baz"]andcall_keywords = {}importlib.import_module("foo", package="bar.baz")results incall_args = ["foo"]andcall_keywords = {"package": "bar.baz"}importlib.import_module(name="foo", package="bar.baz")results incall_args = []andcall_keywords = {"name": "foo", "package": "bar.baz"}The simplest approach is to use
context.call_args_countand if the call_args_count is larger than 0, callcall_args[0]which will choosefoo. If call_args_count is equal to 0 then we need to choosenamefrom the call_keywords.I haven't found previous tests covering the blacklisting importlib functionality so if anyone more fluent in the codebase could point me in the direction of where this should be tested I can add the test cases for this functionality.