Check for hardcoded passwords in class attributes#766
Merged
ericwb merged 4 commits intoFeb 8, 2022
Conversation
B105:hardcoded_password_string currently throws an error for string literal variables, dictionary keys, and comparisons which look like passwords, but does not create an error for class attributes which look like passwords. For example password = "mypassword" and password == "mypassword" would create an error, but my_object.password = "mypassword", and my_object.password == "mypassword" would not. This behavior is unintuitive. Resolves PyCQA#759
noliverio
requested review from
ericwb,
ghugo,
lukehinds and
sigmavirus24
as code owners
sigmavirus24
requested changes
Dec 20, 2021
Member
sigmavirus24
left a comment
sigmavirus24
left a comment
There was a problem hiding this comment.
There are no tests here that validate that this will not regress or that this works in the first place.
Contributor
Author
|
Shoot, sorry about that. d038529 Adds tests for the new functionality. |
Member
|
@sigmavirus24 The included additional tests look good to me. Wanna take a look? |
sigmavirus24
approved these changes
Feb 8, 2022
This was referenced Feb 28, 2022
Merged
This was referenced Feb 28, 2022
Merged
chore(deps): update pre-commit hook pycqa/bandit to v1.7.3
browniebroke/flake8-django-migrations#174
Merged
This was referenced Mar 6, 2022
This was referenced Mar 14, 2022
This was referenced Mar 26, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B105:hardcoded_password_string currently throws an error for string
literal variables, dictionary keys, and comparisons which look like
passwords, but does not create an error for class attributes which look
like passwords.
For example password = "mypassword" and password == "mypassword"
would create an error, but my_object.password = "mypassword",
and my_object.password == "mypassword" would not.
This behavior is unintuitive.
Resolves #759