refactor: split long functions into smaller functions#318
Merged
weibullguy merged 21 commits intomasterfrom Jul 23, 2025
Merged
refactor: split long functions into smaller functions#318weibullguy merged 21 commits intomasterfrom
weibullguy merged 21 commits intomasterfrom
Conversation
* Use TokenInfo objects directly instead of tuples with attributes from TokenInfo objects. * Move non-formatting functions to other modules. * Add functions to determine number of blank lines after docstring for modules, classes, functions, and attributes. * Add function to update the token indices after removing unnecessary blank lines. * Add method to insert appropriate number of blank lines after each type of docstring.
This was
linked to
issues
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a large refactoring of the code base to make things more maintainable. It splits long, complex functions into smaller functions that perform a single task. New modules are introduced to better group functions by their intended purpose. Added 243 new tests and rewrote the test files to use pytest's
parametrizefunction along with toml files containing inputs and expected outputs for each test.The following issues were also addressed by chance:
Closes #264
Closes #270
Closes #282