Fix new type error #489
Merged
Fix new type error #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/typeshed#11880 correctly points out that not all AST nodes have a line and column number.
JelleZijlstra
commented
May 18, 2024
AlexWaygood
reviewed
May 18, 2024
Collaborator
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Maybe a protocol would be a better fit here? Any node will do as long as it has a lineno and col_offset
This comment has been minimized.
This comment has been minimized.
Member
It might even be worthwhile to add such a protocol to typeshed, considering that this will be a fairly common use case. |
Collaborator
Yeah — or perhaps But for now I think we could just roll our own |
|
This change has no effect on typeshed. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python/typeshed#11880 correctly points out that not all AST nodes have a line and column number.