Skip to content

Issue/1427/isort shouldnt move import comments#1430

Merged
timothycrosley merged 2 commits into
developfrom
issue/1427/isort-shouldnt-move-imports
Aug 30, 2020
Merged

Issue/1427/isort shouldnt move import comments#1430
timothycrosley merged 2 commits into
developfrom
issue/1427/isort-shouldnt-move-imports

Conversation

@timothycrosley
Copy link
Copy Markdown
Member

Fixes #1427: keeps isort from moving comments on * imports to other import statements

@timothycrosley
Copy link
Copy Markdown
Member Author

Will merge despite failing integration tests, as I've confirmed these are just due to python-poetry/poetry#2864 not being merged yet, and not any unexpected formatting changes caused by the change.

@timothycrosley timothycrosley changed the title Issue/1427/isort shouldnt move imports Issue/1427/isort shouldnt move import comments Aug 30, 2020
@timothycrosley timothycrosley merged commit 281dfbc into develop Aug 30, 2020
@staticdev staticdev deleted the issue/1427/isort-shouldnt-move-imports branch December 11, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

noqa comment is moved from star import to constant import

1 participant