-
-
Notifications
You must be signed in to change notification settings - Fork 611
Dependency updates round 1 #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 39 39
Lines 3094 3095 +1
Branches 787 787
=======================================
+ Hits 3067 3068 +1
Misses 15 15
Partials 12 12 |
|
@matthewhughes934 This can be rebased on |
Mostly as a matter of consistency. For `isort/__init__.py` this exception looks to not be needed since be0fbd0 An exception is kept in pace for an example file in tests as the contents of the file are just for testing.
This looks to have been accidentally removed with f7a6b0e, `setuptools` is still required in `isort.setuptools_commands`
* `ipython` was removed with 49b41a5 * `smmap2` looking at the history with `git log -G smmap --name-only --oneline` suggests this was only ever defined in `poetry.lock`/`pyproject.toml`. Given this is a library and not providing something extra like e.g. a `flake8` plugin it should be safe to remove
b30c9b1 to
e53ab0f
Compare
👍 no worries, I've just rebased ✅ |
DanielNoord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
First round of upstreaming some improvements, mostly around
dependencies, from https://github.com/matthewhughes934/isort-fork
Remove some
flake8exceptionsMostly as a matter of consistency. For
isort/__init__.pythisexception looks to not be needed since
be0fbd0
An exception is kept in pace for an example file in tests as the
contents of the file are just for testing.
Restore
setuptoolsas optional dependencyThis looks to have been accidentally removed with
f7a6b0e,
setuptoolsis still requiredin
isort.setuptools_commandsDrop some unused dependencies
ipythonwas removed with 49b41a5smmap2looking at the history withgit log -G smmap --name-only --onelinesuggests this was only ever defined inpoetry.lock/pyproject.toml. Given this is a library and notproviding something extra like e.g. a
flake8plugin it should besafe to remove