Skip to content

Fix the Plone profile to be compatible with black#2457

Merged
DanielNoord merged 1 commit into
PyCQA:mainfrom
ale-rt:ale/2456/fix-plone-profile
Feb 1, 2026
Merged

Fix the Plone profile to be compatible with black#2457
DanielNoord merged 1 commit into
PyCQA:mainfrom
ale-rt:ale/2456/fix-plone-profile

Conversation

@ale-rt
Copy link
Copy Markdown
Contributor

@ale-rt ale-rt commented Jan 28, 2026

Fixes #2456

@ale-rt
Copy link
Copy Markdown
Contributor Author

ale-rt commented Jan 28, 2026

CC @mauritsvanrees (the Plone release manager) and previous contributor to isort, see #1926

- **force_alphabetical_sort**: `True`
- **force_single_line**: `True`
- **lines_after_imports**: `2`
- **line_length**: `200`
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ale-rt ale-rt force-pushed the ale/2456/fix-plone-profile branch from 841a76e to 293c201 Compare January 28, 2026 08:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (024aa37) to head (293c201).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2457   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          39       39           
  Lines        3057     3057           
  Branches      675      675           
=======================================
  Hits         3034     3034           
  Misses         13       13           
  Partials       10       10           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielNoord DanielNoord added this pull request to the merge queue Feb 1, 2026
Merged via the queue into PyCQA:main with commit e8c127b Feb 1, 2026
22 checks passed
@mauritsvanrees
Copy link
Copy Markdown
Contributor

It would be good to have this in a release. We have several open automatic pre-commit update PRs like this one that update black, and we can't merge them until there is a new version of isort, because without it the QA tests fail.

But "pre-commit driven development" (or dependabot driven development) isn't a good reason to disrupt your day. We shouldn't be slaves to the machines.

So no pressure. Just a friendly nudge. :-)

@DanielNoord
Copy link
Copy Markdown
Member

No, but users being annoyed by something is.

New release is available on PyPI: https://pypi.org/project/isort/

@ale-rt ale-rt deleted the ale/2456/fix-plone-profile branch February 20, 2026 05:50
@mauritsvanrees
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plone profile is not compatible anymore with the recent black

3 participants