Merged
Conversation
Collaborator
Author
|
I have found the mistake for the new algorithm, and it seems to work in all cases I have tested. I have subsequently disabled the old code path, as I could not find the error until now. We might consider disabling the mixture tests or marking them as slow, as they take some time to finish. |
domna
approved these changes
Jun 19, 2024
Member
domna
left a comment
domna
left a comment
There was a problem hiding this comment.
I would remove the comments and re-add them if we want to activate them in the future. I did not fully check the algorithm but I think you did enough successful checking already.
MarJMue
added a commit
that referenced
this pull request
Jun 20, 2024
* Fix documentation typos * Correct faulty comparison * Implement Rouseel-Vanhellemont-Meas algorithm * Fix RVM algorithm * Disable Jansson code for now * Include new tests for mixture materials * Remove commented-out code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection of the correct root in the Jansson algorithm was faulty.
This PR fixes one bug in the algorithm, but some numerical problems persist.
Additionally, a new method got implemented which seems to be more stable.
ToDo: