Skip to content

Use OIDC for publishing#184

Merged
domna merged 4 commits intomasterfrom
update-publishing-cicd
Jul 17, 2024
Merged

Use OIDC for publishing#184
domna merged 4 commits intomasterfrom
update-publishing-cicd

Conversation

@domna
Copy link
Member

@domna domna commented Jul 16, 2024

This updates the publishing routine based on this guide.

Added features

  • creates an automatic release on tagging, hence we only need to tag and anything will be created automatically
  • adds the packages to the github release
  • signs the github packages with sigstore

Remarks

In principle it's also possible to upload each build to test.pypi to make it available. However, the setuptools scm version makes problems in this case because it always contains a localpart (+g<hash>) which is not allowed for test.pypi. There are discussions for adapting this behaviour (pypa/setuptools-scm#455 and pypa/setuptools-scm#478). I decided for now that this feature is not really important for, so I removed it. Just wanted to mention it here in case we want to have it in the future.

@domna domna marked this pull request as ready for review July 16, 2024 16:08
@domna domna self-assigned this Jul 17, 2024
Copy link
Collaborator

@MarJMue MarJMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@domna domna merged commit e7cc018 into master Jul 17, 2024
@domna domna deleted the update-publishing-cicd branch July 17, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants