Conversation
domna
approved these changes
Oct 1, 2024
Member
domna
left a comment
domna
left a comment
There was a problem hiding this comment.
One small comment, which is not a hard blocker.
Thank you for the changes!
Member
There was a problem hiding this comment.
I would maybe call this file utils.py for future extensions or directly put it in the __init__.py. Seems a bit overkill to have this file for one function and it's unlikely that new functions will be added to this file.
Collaborator
Author
There was a problem hiding this comment.
Sure, will do. Tried to avoid repeating and was not entirely sure if you should put actual code in the init.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for inclusion of chardet, to determine file encoding, as discussed in #192.
As far as I understand, Nexus is binary with fixed encoding handled by h5py?