-
Notifications
You must be signed in to change notification settings - Fork 7
Provide origin info at the channel level in h5 files #33
Provide origin info at the channel level in h5 files #33
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.0.x_dev #33 +/- ##
=============================================
+ Coverage 76.82% 76.84% +0.02%
=============================================
Files 17 17
Lines 3741 3753 +12
=============================================
+ Hits 2874 2884 +10
- Misses 867 869 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if self.backend == 'tables': | ||
| group = self._h5file.create_group(where, name, title) | ||
| for key, value in kwargs.items(): | ||
| if not hasattr(group._v_attrs, key): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using a protected attribute specific to one hdf5 backend (._v_attrs), you should use the attrs property instead I introduced in h5backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the backend is tables the group is of type tables.group.Group (defined in pytables) and doesn't have a attrs property. Even if I add one, it will not be saved. Also, It is backed by the documentation:
Setting and getting user attributes
PyTables provides an easy and concise way to complement the meaning of your node objects on the tree by using the AttributeSet class (see The AttributeSet class). You can access this object through the standard attribute attrs in Leaf nodes and _v_attrs in Group nodes.
PyMoDAQ now also saves the
originprovided in thedwaat the CHXX level in h5 files.