Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@malik-irain
Copy link
Contributor

PyMoDAQ now also saves the origin provided in the dwa at the CHXX level in h5 files.

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (d35316f) to head (bc93cb3).
Report is 9 commits behind head on 5.0.x_dev.

Files with missing lines Patch % Lines
src/pymodaq_data/h5modules/backends.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           5.0.x_dev      #33      +/-   ##
=============================================
+ Coverage      76.82%   76.84%   +0.02%     
=============================================
  Files             17       17              
  Lines           3741     3753      +12     
=============================================
+ Hits            2874     2884      +10     
- Misses           867      869       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if self.backend == 'tables':
group = self._h5file.create_group(where, name, title)
for key, value in kwargs.items():
if not hasattr(group._v_attrs, key):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using a protected attribute specific to one hdf5 backend (._v_attrs), you should use the attrs property instead I introduced in h5backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the backend is tables the group is of type tables.group.Group (defined in pytables) and doesn't have a attrs property. Even if I add one, it will not be saved. Also, It is backed by the documentation:

Setting and getting user attributes

PyTables provides an easy and concise way to complement the meaning of your node objects on the tree by using the AttributeSet class (see The AttributeSet class). You can access this object through the standard attribute attrs in Leaf nodes and _v_attrs in Group nodes.

@seb5g seb5g merged commit b8c132c into PyMoDAQ:5.0.x_dev Mar 7, 2025
11 of 12 checks passed
@malik-irain malik-irain deleted the feature/h5browser-add-origin-to-channel branch October 13, 2025 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants