Fix for compatibility checker & possibility to chose where to save a report when used as a library #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb5g
reviewed
Mar 12, 2025
| pip install hatch pyqt5 | ||
| pip install git+https://github.com/PyMoDAQ/PyMoDAQ.git@${{ matrix.pymodaq-version }} | ||
| if [[ "${{ matrix.pymodaq-version }}" = "latest" ]]; then |
seb5g
requested changes
Mar 12, 2025
| else | ||
| pymodaq="git+https://github.com/PyMoDAQ/PyMoDAQ.git@${{ matrix.pymodaq-version }}" | ||
| fi | ||
| python src/pymodaq_plugin_manager/compatibility_checker.py "${pymodaq}" |
Contributor
There was a problem hiding this comment.
because it is installed one could use : python -m pymodaq_plugin_manager.compatibility, no?
Contributor
There was a problem hiding this comment.
it's no big deal, I'll meage it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25 by re-implementing the way to get version.
It fixes the github action to check compatibility. Now it checks with branch 4.4.x and the latest main one.
Also,
PyMoDAQPlugin.save_xxx_reportmethods now accept a parameter to chose where to save the report.(A new release should be done when accepting the PR.)