-
Notifications
You must be signed in to change notification settings - Fork 8
Keithley27XX viewer + harware added #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seb5g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR,
please look at the comments
also you should consider using the already existing driver from pymeasure:
https://pymeasure.readthedocs.io/en/latest/api/instruments/keithley/keithley2700.html
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Outdated
Show resolved
Hide resolved
|
do you want me to review it? Then you should reply to each of my review points for me to know if you took it into consideration |
|
Oh sorry I indeed worked on your review points but since I was mainly checking them from the "Files chanded" section I just saw most of them disappeared when I pushed the commits and forgot to reply to each in the "Conversation" section. I still want to change the FRONT/REAR parameters to make them show/hide but I will reply to each preview point I worked on. |
seb5g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the presence of the SQL requirements. Other that this, it is fine. Make sure to have a look at the pymeasure implementation!
src/pymodaq_plugins_keithley/daq_viewer_plugins/plugins_0D/daq_0Dviewer_Keithley27XX.py
Show resolved
Hide resolved
|
Thanks ! I checked the pymeasure package recently and I am thinking of how I can use it to implement a 2nd version of the keithley_plugin with pymeasure. I'm not sure all the features I use are on pymeasure but I will try to fork pymeasure and add them if needed. |
|
Thanks for the work! |
|
With pleasure, thank you too ! |
Dev/keithley2100 copy27xx
Here is the implementation i made for using keithley multimeters from the 2700 series (tested with 2700/2701).