Skip to content

Conversation

@Soungai00
Copy link
Contributor

Here is the implementation i made for using keithley multimeters from the 2700 series (tested with 2700/2701).

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR,
please look at the comments
also you should consider using the already existing driver from pymeasure:
https://pymeasure.readthedocs.io/en/latest/api/instruments/keithley/keithley2700.html

@seb5g
Copy link
Contributor

seb5g commented Jul 4, 2024

do you want me to review it? Then you should reply to each of my review points for me to know if you took it into consideration

@Soungai00
Copy link
Contributor Author

Oh sorry I indeed worked on your review points but since I was mainly checking them from the "Files chanded" section I just saw most of them disappeared when I pushed the commits and forgot to reply to each in the "Conversation" section. I still want to change the FRONT/REAR parameters to make them show/hide but I will reply to each preview point I worked on.

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the presence of the SQL requirements. Other that this, it is fine. Make sure to have a look at the pymeasure implementation!

@Soungai00 Soungai00 requested a review from seb5g July 19, 2024 12:03
@Soungai00
Copy link
Contributor Author

Thanks ! I checked the pymeasure package recently and I am thinking of how I can use it to implement a 2nd version of the keithley_plugin with pymeasure. I'm not sure all the features I use are on pymeasure but I will try to fork pymeasure and add them if needed.

@seb5g seb5g merged commit 49627cd into PyMoDAQ:main Jul 19, 2024
@seb5g
Copy link
Contributor

seb5g commented Jul 19, 2024

Thanks for the work!
I released a new version including your instrument!

@Soungai00 Soungai00 deleted the Keithley27XX branch July 19, 2024 14:10
@Soungai00
Copy link
Contributor Author

With pleasure, thank you too !

nano713 pushed a commit to nano713/pymodaq_plugins_keithley that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants