This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Feature/compare threadcommands #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.0.x_dev #50 +/- ##
=============================================
+ Coverage 73.38% 73.43% +0.04%
=============================================
Files 18 18
Lines 1608 1611 +3
=============================================
+ Hits 1180 1183 +3
Misses 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenediktBurger
force-pushed
the
feature/compare-threadcommands
branch
from
e0639a2 to
e02b018
Compare
seb5g
suggested changes
Jul 15, 2025
| PackageNotFoundError = metadata.PackageNotFoundError # for use elsewhere | ||
|
|
||
|
|
||
| if version_mod.parse(platform.python_version()) >= version_mod.parse('3.9'): |
Contributor
There was a problem hiding this comment.
why did you remove this? This is used elsewhere as an import
maybe just add the comment: # for use elsewhere
Contributor
Author
There was a problem hiding this comment.
I see. In this case I'll add a comment.
The last commit was an optional cleanup.
BenediktBurger
force-pushed
the
feature/compare-threadcommands
branch
from
e02b018 to
8dd4f6b
Compare
seb5g
approved these changes
Jul 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds equal comparison for ThreadCommands (extracted from PyMoDAQ/PyMoDAQ#405)