This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Feature/threadcommand serialization including args and kwargs #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenediktBurger
approved these changes
Aug 28, 2025
Contributor
BenediktBurger
left a comment
BenediktBurger
left a comment
There was a problem hiding this comment.
A few comments and suggestions, especially regarding typing.
| return list_obj, remaining_bytes | ||
|
|
||
|
|
||
| class TupleSerializeDeserialize(SerializableBase): |
Contributor
There was a problem hiding this comment.
Instead of tuple serialization, we could use the list conversion in the ThreadCommand serialization.
Contributor
Author
There was a problem hiding this comment.
yes well I used the List Serialization within the Tuple one so it's more or less the same
Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
…com/PyMoDAQ/pymodaq_utils into feature/threadcommand_serialization
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0.x_dev #56 +/- ##
=============================================
+ Coverage 74.26% 74.71% +0.45%
=============================================
Files 18 18
Lines 1628 1665 +37
=============================================
+ Hits 1209 1244 +35
- Misses 419 421 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #53