Update UI tests for Rust 1.46#1121
Merged
davidhewitt merged 1 commit intoPyO3:masterfrom Aug 29, 2020
Merged
Conversation
Member
Author
|
Hmm unsuprisingly MSRV test fails after the update! I'll find a way to disable the UI tests on MSRV. |
Member
|
@davidhewitt
Please check how |
davidhewitt
force-pushed
the
update-ui-tests
branch
2 times, most recently
from
e2aa957 to
c306475
Compare
Member
Author
|
Thanks, I've updated the code in |
davidhewitt
force-pushed
the
update-ui-tests
branch
from
c306475 to
42296ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new Rust 1.46 it looks like the output on the UI tests has improved slightly. Unfortunately this has broken CI 😄