docs: add detail to wrapper type conversions#1157
Merged
davidhewitt merged 1 commit intoPyO3:masterfrom Sep 6, 2020
Merged
Conversation
kngwyu
approved these changes
Sep 6, 2020
Member
kngwyu
left a comment
kngwyu
left a comment
There was a problem hiding this comment.
LGTM, please merge this at your own convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a look at writing a table for #376. This table ended up being big and confusing, and also not possible to doctest. So in the end I decided it was better to extend the existing examples on
types.md.At the same time I also made the language more consistent and simpler.
Now every example is of the same format, e.g.
Closes #376