Fix cargo test with Anaconda python, and divergent gcc versions.#1175
Merged
davidhewitt merged 2 commits intoPyO3:masterfrom Sep 11, 2020
arrjaytee:thatcr-fix-anaconda-python
Merged
Fix cargo test with Anaconda python, and divergent gcc versions.#1175davidhewitt merged 2 commits intoPyO3:masterfrom arrjaytee:thatcr-fix-anaconda-python
davidhewitt merged 2 commits intoPyO3:masterfrom
arrjaytee:thatcr-fix-anaconda-python
Conversation
Member
|
🚀 thanks very much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change forces pyo3 to use python from a shared library when using Anaconda python distributions. Currently cargo test fails with:
unless you match the gcc version with Anaconda's.
Anaconda includes both static and shared versions of python however the python executable is static, so build.rs pyo3 embeds the libpython*.a file, built with Anaconda's gcc 7.3.
This causes the tests and downstream crates to see it also and breaks builds where a different version of gcc is used as the LTO versions in the archive become unsupported.
With this change we always use the .so and avoid any embedded LTO issues altogether.