Add PyDateTime::new_with_fold() method#1398
Merged
davidhewitt merged 5 commits intoPyO3:masterfrom Jan 24, 2021
Merged
Conversation
Member
|
👍 thanks very much for this! While adding this function, would you be willing to add an accompanying test please? (I know the other methods in this file aren't tested; that's an accident of history. 😄 ) |
davidhewitt
approved these changes
Jan 24, 2021
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks very much for this!
Contributor
Author
|
Thank you for all the kind feedback you keep giving! :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTimealready has a new_with_fold() method;PyDateTimeneeds one for consistency and, more importantly, to be able to handle leap seconds correctly.