pyo3-build-config: fix build for windows gnu targets#1759
Closed
davidhewitt wants to merge 5 commits intoPyO3:mainfrom
Closed
pyo3-build-config: fix build for windows gnu targets#1759davidhewitt wants to merge 5 commits intoPyO3:mainfrom
davidhewitt wants to merge 5 commits intoPyO3:mainfrom
Conversation
davidhewitt
force-pushed
the
windows-gnu
branch
from
490743d to
96fefc9
Compare
messense
approved these changes
Aug 6, 2021
Member
Author
|
Cherry-picked this onto #1758 to write more test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks the logic from #1423 to use mingw lib names only if
sysconfig.get_platform()returns"mingw".It's built on top of #1758, because I did a lot of changes in that PR and I didn't want to have to rebase 😅. Only the last commit is relevant for this PR.
Fixes PyO3/setuptools-rust#147
cc @Quogu - I verified this appears to work locally. If you have the chance to check this patch with your use case in the next couple days before I put PyO3 0.14.2 live, it'd be great to have confirmation this resolves your issue.