Merged
Conversation
davidhewitt
changed the title
davidhewitt
force-pushed
the
fix-s390x
branch
2 times, most recently
from
992b27b to
bd35998
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regressions for s390x reported in #1824, and adds some crude CI jobs which should prevent this happening again. Adds the same CI coverage for the
wasm32-wasitarget.I don't actually try and run the tests on either platform, however I do at least check the build. If there are other targets we're aware are in use but are hard to actually test in CI, we could cover them too.