pyo3-macros-backend: Replace pyo3-build-config with abi3 feature#2243
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Mar 23, 2022
Merged
pyo3-macros-backend: Replace pyo3-build-config with abi3 feature#2243davidhewitt merged 1 commit intoPyO3:mainfrom
pyo3-build-config with abi3 feature#2243davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
Python 3.6 and older are not supported by the current PyO3 version, so the removed interpreter version check was a no-op. `pyo3_build_config::get()` attempts to read a config file from disk when PyO3 is cross-compiling, which is probably bad for rust-analyzer and other IDEs that attempt to sandbox the proc macro code.
davidhewitt
approved these changes
Mar 23, 2022
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Haha this is an excellent observation!
It used to not be possible when we also needed to support Python 3.6 (which didn't have fastcall). However, for now this method works well and I agree is more reliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.6 and older are not supported by the current PyO3 version,
so the removed interpreter version check was a no-op.
pyo3_build_config::get()attempts to read a config file from diskwhen PyO3 is cross-compiling, which is probably bad for rust-analyzer
and other IDEs that attempt to sandbox the proc macro code.