Skip to content

Rust 1.62#2489

Merged
davidhewitt merged 3 commits intoPyO3:mainfrom
mejrs:new_rust
Jul 2, 2022
Merged

Rust 1.62#2489
davidhewitt merged 3 commits intoPyO3:mainfrom
mejrs:new_rust

Conversation

@mejrs
Copy link
Copy Markdown
Member

@mejrs mejrs commented Jul 1, 2022

No description provided.

<&'py LimitOverrunError as pyo3::FromPyObject<'py>>
<&'py PanicException as pyo3::FromPyObject<'py>>
<&'py PyAny as pyo3::FromPyObject<'py>>
and 142 others
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number here seems to fluctuate. Can it be wildcarded out?

Copy link
Copy Markdown
Member

@davidhewitt davidhewitt Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not aware of a wildcard feature in trybuild.

Wild guess, could it be related to features? Maybe we need to run UI tests only with feature = "full"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a good idea.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no-fail-fast has answered it, looks like different number of Clone implementations on Windows vs other OS.

I guess it's fine to run this particular UI test just on Linux?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no-fail-fast has answered it, looks like different number of Clone implementations on Windows vs other OS.

That, and the abi3/full/etc features. I've just made a compile_fail doctest instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think that's good enough here, thanks 👍

@mejrs mejrs added the CI-no-fail-fast If one job fails, allow the rest to keep testing label Jul 2, 2022
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again 👍

@davidhewitt davidhewitt merged commit 58d4ba8 into PyO3:main Jul 2, 2022
davidhewitt pushed a commit to davidhewitt/pyo3 that referenced this pull request Jul 26, 2022
* Rust 1.62

* Make rust happy

* Just use a doctest instead

Co-authored-by: mejrs <>
davidhewitt pushed a commit to davidhewitt/pyo3 that referenced this pull request Jul 26, 2022
* Rust 1.62

* Make rust happy

* Just use a doctest instead

Co-authored-by: mejrs <>
davidhewitt pushed a commit to davidhewitt/pyo3 that referenced this pull request Jul 26, 2022
* Rust 1.62

* Make rust happy

* Just use a doctest instead

Co-authored-by: mejrs <>
davidhewitt pushed a commit to davidhewitt/pyo3 that referenced this pull request Jul 27, 2022
* Rust 1.62

* Make rust happy

* Just use a doctest instead

Co-authored-by: mejrs <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast If one job fails, allow the rest to keep testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants