pyproto: remove deprecated feature#2587
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Sep 6, 2022
Merged
Conversation
Member
|
What about #2326 (comment) ? You might be able to remove even more code 🙂 |
Member
Author
|
Maybe, you mean converting over from |
Member
|
Sounds good 👍 |
davidhewitt
force-pushed
the
no-more-pyproto
branch
from
05849f7 to
1ff9ac3
Compare
Member
Author
|
With 0.17.1 out I'm going to merge this now so that it's easier for us to make new changes that we were blocked on before. |
davidhewitt
force-pushed
the
no-more-pyproto
branch
from
1ff9ac3 to
5718ade
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
#[pyproto]- quite a big purge of the codebase!Might hold off on merging this just for a little bit in case 0.17 needs some quick fixes (just to avoid the bother of having to cherry-pick).