docs: Fix pyo3-build-config dependency advice in guide#2640
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Sep 25, 2022
Merged
docs: Fix pyo3-build-config dependency advice in guide#2640davidhewitt merged 2 commits intoPyO3:mainfrom
davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
smheidrich
changed the title
adamreichold
approved these changes
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things are wrong with the guide's advice on how to get
#[cfg]flags frompyo3-build-config:version = ...specification to be put inCargo.tomlis enclosed in double quotes instead of curly braces.use_pyo3_cfgs()is only available if theresolve-configfeature is enabled, which isn't mentioned.This PR fixes both of these.