Skip to content

PyList::as_tuple() -> PyList::to_tuple()#3043

Merged
bors[bot] merged 1 commit intoPyO3:mainfrom
davidhewitt:list-to-tuple
Mar 12, 2023
Merged

PyList::as_tuple() -> PyList::to_tuple()#3043
bors[bot] merged 1 commit intoPyO3:mainfrom
davidhewitt:list-to-tuple

Conversation

@davidhewitt
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt commented Mar 12, 2023

As discussed as a follow-up to #3042

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Mar 12, 2023
@davidhewitt davidhewitt mentioned this pull request Mar 12, 2023
Merged
@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Mar 12, 2023

(I also simplified the inner implementation a bit.)

@davidhewitt davidhewitt mentioned this pull request Mar 12, 2023
Merged
@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Mar 12, 2023

bors r=mejrs

bors bot added a commit that referenced this pull request Mar 12, 2023
@bors @davidhewitt
Merge #3043
178869b 
3043: `PyList::as_tuple()` -> `PyList::to_tuple()` r=mejrs a=davidhewitt

As discussed as a follow-up to #3042 

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Mar 12, 2023

Build failed:

@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Mar 12, 2023

bors retry

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Mar 12, 2023

Build succeeded:

  • conclusion

@bors bors bot merged commit 11c8d0e into PyO3:main Mar 12, 2023
bors bot added a commit that referenced this pull request Mar 18, 2023
@bors @davidhewitt
Merge #3044
ebd417c 
3044: Add `PyTuple::to_list` r=davidhewitt a=davidhewitt

Companion to #3043. I've included benchmarks which suggests that this method is indeed about 25% faster on my machine.

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrs mejrs mejrs approved these changes

Assignees

No one assigned

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhewitt @mejrs