Rename sequence .list() and .tuple() to .to_list() and .to_tuple()#3111
Merged
Rename sequence .list() and .tuple() to .to_list() and .to_tuple()#3111
.list() and .tuple() to .to_list() and .to_tuple()#3111Conversation
davidhewitt
force-pushed
the
to_conversions
branch
from
e7336f0 to
eb4ba53
Compare
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 18, 2023
3111: Rename sequence `.list()` and `.tuple()` to `.to_list()` and `.to_tuple()` r=adamreichold a=davidhewitt As agreed in #3042 (comment). The motivation is that it is an emerging Rust convention for `to_x` to mean "a non-consuming conversion to type x which has some (small) overhead". E.g. `to_string`, `to_owned`. Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Contributor
|
Timed out. |
Member
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed in #3042 (comment).
The motivation is that it is an emerging Rust convention for
to_xto mean "a non-consuming conversion to type x which has some (small) overhead". E.g.to_string,to_owned.