Conversation
3188: Verify that macros do work without any imports r=adamreichold a=lifthrasiir Currently virtually all (positive) tests import `pyo3::prelude::*`, making it hard to detect a certain class of bugs. This PR adds an explicit test that never imports from `pyo3` to fix this. Also this fixes a minor bug from #3157 which didn't work without `use pyo3::types::PyType;`. I think this should be a part of 0.19.0 (#3187), so no additional changelog would be required (as this feature is new in 0.19.0). Co-authored-by: Kang Seonghoon <public+git@mearie.org>
davidhewitt
force-pushed
the
release-0.19
branch
2 times, most recently
from
7dea43b to
501d159
Compare
|
Rebased and I'll push shortly. |
|
(I also added a section to the migration guide to document the changes to |
Thank you and I think this should have been part of the original PR but I never looked back at the guide after writing that one sentence in the class customization section. |
|
Release is live! bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
2 participants
As per #3154 I think we're ready to push 0.19.
I'll put this live on Tuesday evening unless I hear a reason to postpone.