Add IpAddr <-> ipaddress.IPv(4/6)Address conversion

[mhils]

This PR adds support for conversion between Python's ipaddress.IPv4Address/ipaddress.IPv6Address and std::net::IpAddr. 😃

[mhils]

(Please note that you'll either need to squash or rebase into a coherent history at the end before meging.)

To clarify, does this mean that your automation does not squash automatically an I am expected squash myself manually? Happy to do that, I didn't find anything specific in Contributing.md and expected you'd prefer to just press GitHub's squash merge button in the end. :)

[DataTriny]

First time contributor has agreed to the new licensing scheme.

[adamreichold]

(Please note that you'll either need to squash or rebase into a coherent history at the end before meging.)

To clarify, does this mean that your automation does not squash automatically an I am expected squash myself manually? Happy to do that, I didn't find anything specific in Contributing.md and expected you'd prefer to just press GitHub's squash merge button in the end. :)

Our automation is currently bors and it can only always merge or always squash. Since we do like coherent multi-commit histories, we do not squash and hence you need to either squash manually or provide a coherent multi-commit history.

(This is not currently documented, but it is probably not useful ATM as bors-ng will not available for long and we will need to switch to GitHub's merge queues (which seem to have the same issue) soon.)

[adamreichold]

The extract implementation is somewhat broad, but I think this is alright since the conversion are guided by the given types on the Rust side of things.

[adamreichold]

CI fails due to any unused import in the sync module.

[mhils]

CI fails due to any unused import in the sync module.

Fixed, thanks! 🙇

[adamreichold]

@davidhewitt I would want to merge this but would be glad for a second opinion on the broadness of the extract implementation.

[davidhewitt]

Yep, this looks great to me - thanks both and sorry for the delay on my part!

[davidhewitt]

I think we're happy to see this move forward, so I'll click merge now. Thanks again!

[mhils]

Thank you two again! 🍰

It seems like the merge queue has hit an unrelated race condition, happy to fix things here if I'm misreading it. :)

[davidhewitt]

Yep no worries I will get #3225 merged and then retry.