Give a better error message for Python argument in __traverse__#3260
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Jun 20, 2023
Merged
Give a better error message for Python argument in __traverse__#3260davidhewitt merged 1 commit intoPyO3:mainfrom
davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
adamreichold
approved these changes
Jun 20, 2023
davidhewitt
approved these changes
Jun 20, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Agreed, this is a helpful improvement. See also #3180 (which I had originally thought this PR closed until I reread).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ritchie46
pushed a commit
to pola-rs/pyo3
that referenced
this pull request
Dec 5, 2024
Give a better error message for Python argument in __traverse__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it'd be nice to have the docs written in #3168 as a compile error somewhere.