Migrate PyIterator::from_object and PyByteArray::from from AsPyPointer to &PyAny#3389
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Aug 16, 2023
Merged
Migrate PyIterator::from_object and PyByteArray::from from AsPyPointer to &PyAny#3389davidhewitt merged 1 commit intoPyO3:mainfrom
PyIterator::from_object and PyByteArray::from from AsPyPointer to &PyAny#3389davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
alex
force-pushed
the
less-as-py-pointer
branch
from
b720a43 to
74bd91c
Compare
alex
force-pushed
the
less-as-py-pointer
branch
from
74bd91c to
907a717
Compare
…ointer` to `&PyAny`
alex
force-pushed
the
less-as-py-pointer
branch
from
907a717 to
1a904a7
Compare
davidhewitt
approved these changes
Aug 15, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, as discussed on the issue, while this is direct breakage it should be relatively minor for most users and given the need to remove / minimize AsPyPointer I think it's prudent to accept this fallout without a deprecation dance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #3358