Remove usage of AsPyPointer in IntoPy<PyObject> trait implementation#3393
Merged
davidhewitt merged 1 commit intoPyO3:mainfrom Aug 18, 2023
Merged
Remove usage of AsPyPointer in IntoPy<PyObject> trait implementation#3393davidhewitt merged 1 commit intoPyO3:mainfrom
AsPyPointer in IntoPy<PyObject> trait implementation#3393davidhewitt merged 1 commit intoPyO3:mainfrom
Conversation
Member
Author
|
FWIW I believe the set of types here is comprehensive, looking at https://docs.rs/pyo3/latest/pyo3/conversion/trait.AsPyPointer.html#implementors:
|
davidhewitt
reviewed
Aug 16, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
While I think &PyRef and &PyRefMut are extremely rare cases, given the amount of churn we might create for users with all this change to AsPyPointer and IntoPyPointer, it seems fairer to users if we add those impls too. They did exist under the old blanket impl, after all.
Member
Author
|
Easy enough. |
Member
Author
|
Done |
davidhewitt
approved these changes
Aug 18, 2023
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks! One more log on the AsPyPointer bonfire. 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.