Hide GILPool behind a feature to test ability to fully avoid it#3685
Closed
adamreichold wants to merge 1 commit intomainfrom
Closed
Hide GILPool behind a feature to test ability to fully avoid it#3685adamreichold wants to merge 1 commit intomainfrom
adamreichold wants to merge 1 commit intomainfrom
Conversation
davidhewitt
reviewed
Dec 21, 2023
Comment on lines
+147
to
+150
| #[cfg(not(feature = "pool"))] | ||
| let gil = WithGIL::during_call(); | ||
| #[cfg(not(feature = "pool"))] | ||
| let py = gil.python(); |
Member
There was a problem hiding this comment.
Yep this looks the right way to keep py bounded correctly 👍
adamreichold
force-pushed
the
no-pool-build
branch
from
745f858 to
fe3f465
Compare
adamreichold
force-pushed
the
no-pool-build
branch
from
fe3f465 to
7f9b1cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds even if it obviously doesn't work due to
unimplemented!()inregister_owned. cfg'ing this one out and seeing whether we can get the result to compile would be the next after completing thePy2-based API.