implement PyErr::write_unraisable_bound#3698
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Dec 24, 2023
Merged
Conversation
adamreichold
approved these changes
Dec 24, 2023
Member
adamreichold
left a comment
There was a problem hiding this comment.
LGTM. One nit in python_format.
9d6ba62 to
bada22c
Compare
CodSpeed Performance ReportMerging #3698 will improve performances by 22.03%Comparing Summary
Benchmarks breakdown
|
bada22c to
1004ffa
Compare
Member
Author
|
Rebased to fix the compile errors. FYI I added a commit to export |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of the suggestion to go for the
deprecate-and-add-bound-variantapproach, here's a PR which implements this change forPyErr::write_unraisable, as I bumped into this when implementing #3697