add gil-refs feature to aid migration#3707
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Dec 29, 2023
Merged
Conversation
davidhewitt
force-pushed
the
gil-refs-feature
branch
from
c692a53 to
a865291
Compare
This was referenced Dec 28, 2023
adamreichold
approved these changes
Dec 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
I'll push rust 1.75 updates shortly! |
davidhewitt
force-pushed
the
gil-refs-feature
branch
from
a865291 to
a9f867c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #3681 (comment), this PR adds a feature which in 0.21 will disable deprecation warnings related to the to-be-removed GIL Refs API.
@adamreichold: we were using the name
poolin that discussion, however I felt I likedgil-refsslightly more as the users don't typically interact with the GILPool, however the GIL Refs as a concept are very user-facing. If you have a strong preference for the feature to be calledpoolI can rename to that.In PyO3 0.22 we can make this migration stricter by gating the GIL Refs API behind this feature, and emitting deprecation warnings even when this feature is enabled.
Finally in 0.23 or 0.24 we remove this feature and the accompanying APIs.
I have also pushed an accompanying second commit which is an updated copy of #3693 to begin the migration guide entry for this feature.