add PyBackedStr and PyBackedBytes#3802
Merged
adamreichold merged 5 commits intoPyO3:mainfrom Feb 15, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #3802 will degrade performances by 20.41%Comparing Summary
Benchmarks breakdown
|
|
Thank you, this is exactly the kind of code I have used and I see elsewhere for zero-copy of python bytes. What remains to be done in this PR? (I care more about bytes than strings, so would be happy to see this without the UTF8 encode) |
3e9054a to
419ccb3
Compare
adamreichold
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #3708
cc @adamreichold this is inspired by #3784 (comment)
I didn't really want to think too hard about a generic
Tfor this type, instead I wanted to just introduce two special cases which should be able to replace&strorCow<u8>. These types might end up being temporary just until we can add the second lifetime toFromPyObject, or maybe we learn from these and refine further later.This depends on #3801 to compile.