Merged
Conversation
CodSpeed Performance ReportMerging #3806 will degrade performances by 15.63%Comparing Summary
Benchmarks breakdown
|
cfbc3ce to
6f2019f
Compare
Member
|
Sorry for the slight delay, I will do my best to review this tonight. |
davidhewitt
approved these changes
Feb 8, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Fantastic, this is a much more reviewable first step. Thanks again and sorry I was a bit stretched for time in the last couple of days!
Comment on lines
+645
to
+647
| globals.map(PyNativeType::as_borrowed).as_deref(), | ||
| locals.map(PyNativeType::as_borrowed).as_deref(), |
Member
There was a problem hiding this comment.
👍 very tidy temporary solution!
Member
|
Uff rust nightly change broke the merge. |
Member
Author
|
Rebased, to include CI fixes |
Member
|
👍 sorry I forgot to rerun the merge queue, it should have automatically picked them up but I just got sidetracked. |
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3684 and split from #3716
This converts to the
Python::evalfunction to the new API. For easier reviewing this focuses purely oneval/eval_boundand leaves the very similarPython::runmethod as well as thePyDictmethods for followup PRs.