Skip to content

port IntoPyDict to Bound API#3817

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:into-pydict
Feb 11, 2024
Merged

port IntoPyDict to Bound API#3817
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:into-pydict

Conversation

@Icxolu
Copy link
Copy Markdown
Member

@Icxolu Icxolu commented Feb 10, 2024

Part of #3684, split from #3716

This introduces the into_py_dict_bound API on the IntoPyDict trait, and deprecates the old gil-ref API.

Because the diff is already quite large, I kept the deprecation of PyDict::new for a followup PR.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 10, 2024
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yet again, this looks great! Just one possible thought / suggestion...

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 10, 2024

CodSpeed Performance Report

Merging #3817 will degrade performances by 16.95%

Comparing Icxolu:into-pydict (e45fbe4) with main (45f2b0a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 77 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Icxolu:into-pydict Change
sequence_from_list 272.2 ns 327.8 ns -16.95%
f64_from_pyobject 461.1 ns 405.6 ns +13.7%

@davidhewitt davidhewitt added this pull request to the merge queue Feb 11, 2024
Merged via the queue into PyO3:main with commit 07ea89d Feb 11, 2024
@Icxolu Icxolu deleted the into-pydict branch February 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants