Skip to content

Implement PyErr::get_type_bound#3819

Merged
davidhewitt merged 9 commits intoPyO3:mainfrom
LilyFirefly:pyerr-bound
Feb 11, 2024
Merged

Implement PyErr::get_type_bound#3819
davidhewitt merged 9 commits intoPyO3:mainfrom
LilyFirefly:pyerr-bound

Conversation

@LilyFirefly
Copy link
Contributor

Implements more of the Bound api from #3684.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2024

CodSpeed Performance Report

Merging #3819 will degrade performances by 16.95%

Comparing LilyFoote:pyerr-bound (c644893) with main (fa53d81)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main LilyFoote:pyerr-bound Change
list_via_extract 392.2 ns 336.7 ns +16.5%
not_a_list_via_downcast 216.7 ns 244.4 ns -11.36%
f64_from_pyobject 461.1 ns 405.6 ns +13.7%
sequence_from_list 272.2 ns 327.8 ns -16.95%

@LilyFirefly LilyFirefly mentioned this pull request Feb 11, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out with our great API migration!

There's a few thorny edge cases with reference counting that I've caught here. Comments below...

LilyFirefly and others added 6 commits February 11, 2024 11:44
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 11, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Feb 11, 2024
Merged via the queue into PyO3:main with commit baf5c8e Feb 11, 2024
@LilyFirefly LilyFirefly deleted the pyerr-bound branch February 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants