Skip to content

Remove unrequired encoding header#382

Merged
konstin merged 1 commit intoPyO3:masterfrom
Alisa-lisa:patch-1
Mar 28, 2019
Merged

Remove unrequired encoding header#382
konstin merged 1 commit intoPyO3:masterfrom
Alisa-lisa:patch-1

Conversation

@Alisa-lisa
Copy link
Contributor

This is not required anymore for Python 3.

This is not required anymore for Python 3.
@pganssle
Copy link
Member

pganssle commented Mar 3, 2019

This library still supports Python 2 for at least a little while, though, I think.

Also, while not required I don't think it hurts to explicitly declare the encoding of the file even if it's the same as the default.

@kngwyu
Copy link
Member

kngwyu commented Mar 4, 2019

Let's leave it until python2 support ends :)

@kngwyu kngwyu closed this Mar 4, 2019
@konstin
Copy link
Member

konstin commented Mar 4, 2019

Yep, but I think we can keep this open until then.

@konstin konstin reopened this Mar 4, 2019
@konstin konstin added the blocked label Mar 7, 2019
@konstin konstin mentioned this pull request Mar 18, 2019
1 task
@milesgranger
Copy link
Contributor

milesgranger commented Mar 20, 2019

I'd just add that while it's the default (utf-8) for Python3, so far as Python3 is concerned, it makes no difference, but IDEs will can still make use of this declaration.

@konstin konstin merged commit bc7776e into PyO3:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants