Remove unrequired encoding header#382
Merged
konstin merged 1 commit intoPyO3:masterfrom Mar 28, 2019
Alisa-lisa:patch-1
Merged
Conversation
This is not required anymore for Python 3.
Member
|
This library still supports Python 2 for at least a little while, though, I think. Also, while not required I don't think it hurts to explicitly declare the encoding of the file even if it's the same as the default. |
Member
|
Let's leave it until python2 support ends :) |
Member
|
Yep, but I think we can keep this open until then. |
Contributor
|
I'd just add that while it's the default (utf-8) for Python3, so far as Python3 is concerned, it makes no difference, but IDEs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not required anymore for Python 3.