port Python::get_type to Bound API#3846
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Feb 18, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #3846 will degrade performances by 10.2%Comparing Summary
Benchmarks breakdown
|
Member
63 tasks
Member
Author
|
Rebased |
davidhewitt
reviewed
Feb 18, 2024
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, overall looks great! Got a suggestion for the FIXME...
tests/test_inheritance.rs
Outdated
| assert!(sub_ty.is_subclass(base_ty).unwrap()); | ||
| assert!(sub_ty.is_subclass(&base_ty).unwrap()); | ||
|
|
||
| // FIXME: Whats the new API to do this? |
Member
There was a problem hiding this comment.
I think you're looking for Py::new or Bound::new, I guess we should deprecate PyCell::newin favour of one of these.
Member
Author
There was a problem hiding this comment.
Ah, nice and easy! (And thanks for catching, I totally forget that i put that there)
I guess we should deprecate
PyCell::newin favour of one of these.
That's a good idea, I'll look into that 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3684
This ports
Python::get_typeto theBoundAPI. I implemented this on a rebase of #3705 (with minor changes to adapt for changes since creation), so this should compile already. All the changes related to theget_typeconversion are in a separate commit. I'll mark this as draft and rebase this when #3705 lands.