reexport PyAnyMethods and friends from pyo3::types#3895
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Feb 24, 2024
Merged
reexport PyAnyMethods and friends from pyo3::types#3895davidhewitt merged 2 commits intoPyO3:mainfrom
PyAnyMethods and friends from pyo3::types#3895davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
Member
|
Thanks, as per the linked comment I think this is the right solution for how to make these traits public (even if we don't expect most users to import them this way). The nightly failures look related to the changes here, mind fixing them up please? (I had only just fixed the nightly job after a very very long string of failures 😅) |
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3684, following #3832 (comment)
This reexports the traits of
BoundAPI under thepyo3::typesnamespace in addition to the prelude. The prelude is only really meant for glob import, so this is nicer for targeted imports.This also adds
PySliceMethodsto the prelude, which was previously missing.