Skip to content

cleans up PyCFunction::internal_new#3910

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:clean-pyfunction-internal-new
Feb 27, 2024
Merged

cleans up PyCFunction::internal_new#3910
davidhewitt merged 1 commit intoPyO3:mainfrom
Icxolu:clean-pyfunction-internal-new

Conversation

@Icxolu
Copy link
Member

@Icxolu Icxolu commented Feb 27, 2024

Part of #3684, following #3897 (comment)

This deduplicates some code around PyCFunction::internal_new

This deduplicates some code around `PyCFunction::internal_new`
@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Feb 27, 2024
Copy link
Contributor

@LilyFirefly LilyFirefly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tidy up!

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Feb 27, 2024
Merged via the queue into PyO3:main with commit 6f03a54 Feb 27, 2024
@Icxolu Icxolu deleted the clean-pyfunction-internal-new branch February 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants