deprecate wrap_pyfunction with py argument#3954
Merged
davidhewitt merged 4 commits intoPyO3:mainfrom Mar 12, 2024
Merged
Conversation
The Python token in `wrap_pyfunction` is not handled automatically by `WrapPyFunctionArg`, for backwards compatibility. This uses deref specialization to deprecate this variant.
davidhewitt
approved these changes
Mar 12, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, and sorry it took a couple days to get to this; a bit overloaded with family the last couple days. I will look at the other PRs tomorrow 👍
Comment on lines
+80
to
+81
| // should lint but currently does not | ||
| let _ = wrap_pyfunction!(double)(py); |
Member
There was a problem hiding this comment.
Yeah I suspect because of type inference within the closure this one will be hard to make work. But maybe there's a smart way!
Member
Author
There was a problem hiding this comment.
Yeah, it kept inferring from the inside instead of the outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #3847
The Python token in
wrap_pyfunctionis not handled automatically byWrapPyFunctionArg, for backwards compatibility. This uses deref specialization to deprecate this variant.