Change GILGuard to be able to represent a GIL that was already held#4187
Merged
Change GILGuard to be able to represent a GIL that was already held#4187
GILGuard to be able to represent a GIL that was already held#4187Conversation
alex
force-pushed
the
gil-guard-simplification
branch
2 times, most recently
from
01fc4ec to
0367f2d
Compare
davidhewitt
approved these changes
May 16, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
One thought, otherwise LGTM and feel free to merge!
src/gil.rs
Outdated
| /// Indicates the GIL was already held with this GILGuard was acquired. | ||
| Assumed, | ||
| /// Indicates that we actually acquired the GIL when this GILGuard was acquired | ||
| Held { |
Member
There was a problem hiding this comment.
I like the name suggested by @adamreichold
Suggested change
| Held { | |
| Ensured { |
Dr-Emann
reviewed
May 16, 2024
src/gil.rs
Outdated
Comment on lines
165
to
166
| /// If the GIL was already acquired via PyO3, this returns `None`. Otherwise, | ||
| /// the GIL will be acquired and a new `GILPool` created. |
Contributor
There was a problem hiding this comment.
Need a change to the docs of the return value here.
alex
force-pushed
the
gil-guard-simplification
branch
from
0367f2d to
0535563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4181