Skip to content

Move GIL counting from GILPool to GILGuard#4188

Merged
alex merged 1 commit intoPyO3:mainfrom
alex:gil-counting
May 17, 2024
Merged

Move GIL counting from GILPool to GILGuard#4188
alex merged 1 commit intoPyO3:mainfrom
alex:gil-counting

Conversation

@alex
Copy link
Member

@alex alex commented May 16, 2024

No description provided.

@alex alex added the CI-skip-changelog Skip checking changelog entry label May 16, 2024
@alex
Copy link
Member Author

alex commented May 16, 2024

With this change, #4181 should become trivial

@alex alex force-pushed the gil-counting branch 2 times, most recently from 5a3c69f to d0234c3 Compare May 17, 2024 02:47
@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #4188 will improve performances by 10.22%

Comparing alex:gil-counting (d446db7) with main (88f2f6f)

Summary

⚡ 1 improvements
✅ 67 untouched benchmarks

Benchmarks breakdown

Benchmark main alex:gil-counting Change
ordered_dunder_methods 4 µs 3.6 µs +10.22%

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me! 🚀

@davidhewitt davidhewitt enabled auto-merge May 17, 2024 03:10
@alex
Copy link
Member Author

alex commented May 17, 2024

woo. if this merges before I go to bed, I'll rebase #4181

@davidhewitt davidhewitt added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@alex alex enabled auto-merge May 17, 2024 04:11
@alex alex added this pull request to the merge queue May 17, 2024
Merged via the queue into PyO3:main with commit 1c64a03 May 17, 2024
@alex alex deleted the gil-counting branch May 17, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants