Skip to content

fix clippy#4227

Closed
Icxolu wants to merge 1 commit intoPyO3:mainfrom
Icxolu:clippy
Closed

fix clippy#4227
Icxolu wants to merge 1 commit intoPyO3:mainfrom
Icxolu:clippy

Conversation

@Icxolu
Copy link
Copy Markdown
Member

@Icxolu Icxolu commented Jun 2, 2024

Currently I get clippy failures on the two runs with abi3 when running nox -s clippy on main locally. It looks like they originate from #3835. Looking at the feature flags, it seems correct to me that they trigger, but I'm not sure why CI (on main and PRs) does not seem to care...

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Jun 2, 2024
@davidhewitt
Copy link
Copy Markdown
Member

Thanks!

So I think the problem here is that CI runs the clippy-all job, which uses config files to fake the Python interpreter in order to lint all feature configurations.

The problem is that the config files also control the abi3 feature, and I recently realised in #4185 (comment) that this also creates issues with test-debug. I suspect that our CI is a bit broken in both clippy-all and test-debug. :(

I'm not sure what the right solution is; I guess to some extent it requires adding additional complexity in pyo3-build-config...

@Icxolu Icxolu closed this Jul 23, 2024
@Icxolu Icxolu deleted the clippy branch July 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants