Skip to content

Backports for 0.23.x release #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidhewitt merged 6 commits into from
Feb 20, 2025
Merged

Backports for 0.23.x release #4924

davidhewitt merged 6 commits into from
Feb 20, 2025

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented Feb 19, 2025 •
edited
Loading

@mattip @Icxolu @mgorny
Add PyPy3.11 (PyO3#4760)
9151b25 
* allow pypy3.11

* run CI on pypy3.11

* change const declaration

* change link name for PyExc_BaseExceptionGroup

* PyObject_DelAttr* are inline functions on pypy3.11

* use nightly until official release

* DOC: add a news fragment

* conditionally compile 'use' statements

* fix format

* changes from review

* pypy 3.11 released

* fixes for PyPy

* typo

* exclude _PyInterpreterFrame on PyPy

* more pypy fixes

* more excluding _PyFrameEvalFunction on PyPy

* fixes for PyPy struct differences

* format

* fix test

---------

Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
@mgorny
Copy link
Contributor Author

mgorny commented Feb 19, 2025

Sigh, I hate hypothesis health checks.

@mgorny mgorny mentioned this pull request Feb 19, 2025
Closed
@davidhewitt
Copy link
Member

davidhewitt commented Feb 19, 2025

I think picking #4879 might resolve. 😓

LilyFirefly and others added 2 commits February 19, 2025 14:46
@LilyFirefly @mgorny
Fix manual_ok_err clippy lint on nightly (PyO3#4886)
09ac676 
https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
@ngoldbaum @davidhewitt @mgorny
fix multithreaded access to freelist pyclasses (PyO3#4902)
80c4d05 
* make FreeList explicitly a wrapper for *mut PyObject

* fix multithreaded access to freelist pyclasses

* add changelog entry

* use a GILOnceCell to initialize the freelist

* respond to code review

* skip test on wasm

---------

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
@davidhewitt davidhewitt added CI-skip-changelog Skip checking changelog entry CI-build-full labels Feb 19, 2025
@arielb1 @mgorny
avoid FailedHealthCheck in test_double (PyO3#4879)
fe10e2d 
Co-authored-by: Ariel Ben-Yehuda <arielby@amazon.com>
@davidhewitt
Copy link
Member

davidhewitt commented Feb 19, 2025

I think #4912 will fix the benchmarks build.

davidhewitt
davidhewitt reviewed Feb 19, 2025
View reviewed changes
newsfragments/4879.fixed.md
@@ -0,0 +1 @@
* fixed spurious `test_double` failures.
Copy link
Member

@davidhewitt davidhewitt Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, when editing the CHANGELOG later I would probably just omit this line as it's not really user facing.

@mgorny
Copy link
Contributor Author

mgorny commented Feb 19, 2025

Okay, this is green. Do you want me to wait for #4874, or file a separate backport PR for it later?

@mgorny mgorny marked this pull request as ready for review February 19, 2025 15:48
@davidhewitt
Copy link
Member

davidhewitt commented Feb 19, 2025

Let's see if that PR looks likely to land today; if not then I propose we move forward to ship this.

@ngoldbaum
Copy link
Contributor

ngoldbaum commented Feb 19, 2025 •
edited
Loading

Thanks for taking this on @mgorny!

Not to hold this up, but maybe we should include #4921 as well? @nertpinx needed that to get 0.23 working for their codebase.

@ngoldbaum @mgorny
Use a critical section to serialize adding builtins to globals (PyO3#…
0f65852 
…4921)

* add test that panics because __builtins__ isn't available

* use a critical section to serialize adding __builtins__ to __globals__

* add release note

* use safe APIs instead of PyDict_Contains
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #4924 will improve performances by 10.99%

Comparing mgorny:0.23-pypy3.11-backports (0f65852) with release-0.23 (693624c)

Summary

⚡ 1 improvements
✅ 81 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ extract_str_extract_fail 2.1 µs 1.9 µs +10.99%
🆕 tuple_into_pyobject N/A 2.9 µs N/A

@davidhewitt
Copy link
Member

davidhewitt commented Feb 19, 2025

Let's not wait for #4874

@davidhewitt
Copy link
Member

davidhewitt commented Feb 19, 2025

The benchmark measurement change is probably not material and just a result of inlining change or similar.

@mgorny
Copy link
Contributor Author

mgorny commented Feb 20, 2025

Anything else I should do? In particular, should I do the release tasks in this PR, or will this one be merged, and then I should open another one for release tasks?

@davidhewitt
Copy link
Member

davidhewitt commented Feb 20, 2025

I don't have a fixed process for that bit, maybe let's just merge this and do the release steps in a follow up. Thank you again and I'll aim to help ship this tomorrow evening UK time

@davidhewitt davidhewitt merged commit 7599bda into PyO3:release-0.23 Feb 20, 2025
81 checks passed
@davidhewitt
Copy link
Member

davidhewitt commented Feb 22, 2025

With apologies I was unwell yesterday, I may be able to do this tonight instead.

@mgorny
Copy link
Contributor Author

mgorny commented Feb 22, 2025

No problem, I didn't really find time to look into it either.

@mgorny mgorny deleted the 0.23-pypy3.11-backports branch February 22, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

Assignees

No one assigned

Labels

CI-build-full CI-skip-changelog Skip checking changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mgorny @davidhewitt @ngoldbaum @mattip @LilyFirefly @arielb1 @Icxolu