Skip to content

remove deprecated IntoPy and ToPyObject#5010

Merged
Icxolu merged 1 commit intoPyO3:mainfrom
Icxolu:remove-intopy
Mar 29, 2025
Merged

remove deprecated IntoPy and ToPyObject#5010
Icxolu merged 1 commit intoPyO3:mainfrom
Icxolu:remove-intopy

Conversation

@Icxolu
Copy link
Copy Markdown
Member

@Icxolu Icxolu commented Mar 26, 2025

Complement to #4982

@Icxolu Icxolu force-pushed the remove-intopy branch 4 times, most recently from 50983eb to b9f9c67 Compare March 26, 2025 19:46
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 26, 2025

CodSpeed Performance Report

Merging #5010 will not alter performance

Comparing Icxolu:remove-intopy (69f78b5) with main (bd1e7d2)

Summary

✅ 84 untouched benchmarks
⁉️ 3 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ byte_slice_into_py 1.6 µs N/A N/A
⁉️ vec_into_py 9.3 µs N/A N/A
⁉️ tuple_into_py 3 µs N/A N/A

Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup, thank you! Mind if we delay merging this until after I branch a 0.24.1 release? Seems like there's a few things we need to ship fixes for, I'm aiming to dedicate Friday to getting that done.

@Icxolu
Copy link
Copy Markdown
Member Author

Icxolu commented Mar 26, 2025

Mind if we delay merging this until after I branch a 0.24.1 release?

Sure, sounds good 👍

@Icxolu Icxolu added this to the 0.25 milestone Mar 28, 2025
@Icxolu Icxolu enabled auto-merge March 28, 2025 21:55
@Icxolu Icxolu added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Mar 28, 2025
@Icxolu Icxolu enabled auto-merge March 28, 2025 23:04
@Icxolu Icxolu added this pull request to the merge queue Mar 28, 2025
Merged via the queue into PyO3:main with commit a8452c5 Mar 29, 2025
51 of 52 checks passed
@Icxolu Icxolu deleted the remove-intopy branch March 29, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants